Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear scheduled tasks at startup and ensure that the pingback scheduler does not add multiple pingbacks as a result #7954

Closed
rtibbles opened this issue Apr 5, 2021 · 0 comments · Fixed by #7959
Labels
DEV: backend Python, databases, networking, filesystem... P2 - normal Priority: Nice to have
Milestone

Comments

@rtibbles
Copy link
Member

rtibbles commented Apr 5, 2021

Observed behavior

In line with the regular task queue, we clear scheduled tasks at startup.
#7951 changed this behaviour for the regular task queue, but not for the scheduled tasks.

Expected behavior

We should be able to persist scheduled tasks across server restarts.
The 'schedule_pingback` function should not queue a new ping back in the scheduler if one already exists.

User-facing consequences

If we implement scheduled tasks created by the user, they would be cleared every time the server restarted.

@rtibbles rtibbles added DEV: backend Python, databases, networking, filesystem... P2 - normal Priority: Nice to have labels Apr 5, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... P2 - normal Priority: Nice to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant