Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks): tasks queue is cleared on server start #7951

Merged
merged 1 commit into from Apr 5, 2021

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Apr 4, 2021

Summary

When the kolibri server starts, we were clearing the tasks queue which lead us to lose the historical information of completed, failed or cancelled tasks.

This PR fixes the issue by not letting that happen.

Reviewer guidance

  1. Complete some tasks or cancel running tasks.
  2. Restart the server.
  3. See the task manager.
  4. The task list should have persisted.

References

Fixes #6255


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb
Copy link
Member Author

vkWeb commented Apr 4, 2021

cc @jonboiser, @rtibbles for review.

@vkWeb
Copy link
Member Author

vkWeb commented Apr 4, 2021

I think we should clear the tasks from db when the user clears them from the frontend...? This will simplify frontend's logic as we'll just need to display jobs that get return from GET api/tasks/tasks (no filtering) and also it'll save us some memory.

If we move forward with the current implementation then jobs will persist on db forever.

@nucleogenesis nucleogenesis added the TODO: needs review Waiting for review label Apr 5, 2021
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue as stated.

@rtibbles
Copy link
Member

rtibbles commented Apr 5, 2021

Added a follow up issue to do the same for the task scheduler: #7954

@rtibbles rtibbles merged commit 44bf1ed into learningequality:develop Apr 5, 2021
@jonboiser jonboiser added changelog Important user-facing changes and removed TODO: needs review Waiting for review labels Apr 5, 2021
@jonboiser jonboiser added this to the 0.15.0 milestone Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important user-facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants