Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent incomplete shutdown of devserver on mac #8465

Open
indirectlylit opened this issue Sep 24, 2021 · 4 comments
Open

consistent incomplete shutdown of devserver on mac #8465

indirectlylit opened this issue Sep 24, 2021 · 4 comments

Comments

@indirectlylit
Copy link
Contributor

Observed behavior

The devserver does not shut down using ctrl-c for me on mac:

2021-09-24 13 17 07

Originally I reported this in #8376 but moved it to its own issue as the more reproducible scenario.

Errors and logs

image

Expected behavior

Clean shutdown

User-facing consequences

As a dev, need to keep activity monitor open and kill python processes

Steps to reproduce

start devserver and stop it

Context

latest develop

@rtibbles
Copy link
Member

Duplicate of #7955

Note that this is an issue with yarn swallowing keyboard interrupts, so the workaround is to spawn the Python devserver separately.

@indirectlylit
Copy link
Contributor Author

re-opening because in #7955 the python process did eventually shut down, but in this case it does not

@indirectlylit
Copy link
Contributor Author

@rtibbles asked:

Have you tried using npm-run-all instead of run-p and using this flag?

    -r, --race   - - - - - - - Set the flag to kill all tasks when a task
                               finished with zero. This option is valid only
                               with 'parallel' option.

Just tried it and the result is the same. Snippet from package.json:

"devserver": "npm-run-all --parallel --race python-devserver lint-frontend:watch:format hashi-dev watch ",

@indirectlylit
Copy link
Contributor Author

as a workaround in 0f168a6 I added a new frontend-devserver command. My practice is now to run two terminal tabs:

tab 1 tab 2
yarn run frontend-devserver yarn run python-devserver

If we were to update the 'getting started' page with this guidance, we could mitigate the impact of this issue without having to fix it

@marcellamaki marcellamaki added this to the upcoming major milestone Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants