Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent errors for exact duplicate usernames #11755

Conversation

rtibbles
Copy link
Member

Summary

  • Username case error #11716 fixed errors caused by case insensitively matching usernames, but a possible error remained if usernames were exact duplicates (this is possible by the same username being created on different devices, but the same facility and then being synced)
  • This adds a regression test and fixes this issue
  • Also moves querying of the unauthenticated user until after we have failed to login, to avoid an unnecessary premature query.

References

Depends on #11754, as that involved some updates to the authentication logic, and so avoids a merge conflict.

Reviewer guidance

Check that the newly added test makes sense. Check that it passes.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Jan 19, 2024
Ensure we don't error when exact username duplicates exist in a facility.
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this update, and the corresponding test, makes sense to me

@marcellamaki marcellamaki merged commit 85e56d8 into learningequality:release-v0.16.x Feb 27, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants