[DO NOT MERGE UNTIL 0.16.1] Fix Screen Flickering in Libarary page

[iskipu]

Summary

The issue got fixed after converting the margins into to padding.

screen-flicker.mp4

References

fix #11838

Reviewer guidance

…

---

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0rc1.dev0_git.3.g45cdee96.pex
Windows Installer (EXE)	kolibri-0.16.0rc1.dev0+git.3.g45cdee96-unsigned.exe
Debian Package	kolibri_0.16.0rc1.dev0+git.3.g45cdee96-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0rc1.dev0+git.3.g45cdee96-0.4.0.dmg
Android Package (APK)	kolibri-0.16.0rc1.dev0+git.3.g45cdee96-0.1.0-debug.apk
TAR file	kolibri-0.16.0rc1.dev0+git.3.g45cdee96.tar.gz
WHL file	kolibri-0.16.0rc1.dev0+git.3.g45cdee96-py2.py3-none-any.whl

[pcenov]

Hi @iskipu the Android app keeps force stopping when I launch it so there must be something wrong with the .apk build. Could you check why is this so?

[iskipu]

Hi @iskipu the Android app keeps force stopping when I launch it so there must be something wrong with the .apk build. Could you check why is this so?

Hi @pcenov i checked few other apk builds from other PRs and they were not working too !!

[pcenov]

@rtibbles I need to test this in the Android app - could you please have a look and advise what needs to be done so that the app installer is not broken. Thanks!

[iskipu]

Hi @pcenov, @rtibbles had made a fix to the issue, so i rebased the commit and force pushed but not sure why kolibri build is failing any idea how to fix this ?

[rtibbles]

Not your fault, there's another open PR to fix this new issue! Never boring around here!

[iskipu]

Not your fault, there's another open PR to fix this new issue! Never boring around here!

Oh Cool !! i was very confused why it was not working and also this is my first time trying git rebase so i was thinking i am doing something wrong 🤣 🤣

[MisRob]

Thanks @iskipu and @rtibbles. Seems builds are now working, @pcenov.

[pcenov]

Thank you @iskipu - I confirm that the flickering issue is fixed now!

[MisRob]

Hi @iskipu, thanks for the contribution and @pcenov for testing. I haven't noticed any issue related to the change from margin to padding so I think this is good. We will need to wait for merging though because we're about to release 0.16.0 but this change is planned for 0.16.1.

[MisRob]

0.16.0 is out so we can merge