Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade KDS from v2.0.0 to v3.0.1 on the release branch #11929

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Feb 29, 2024

Summary

Release notes

Includes Kolibri code updates related to the breaking change in regards to value --> buttonValue renaming.

Reviewer guidance

  • value --> buttonValue
    • You could check that for all radio buttons I updated, the intention for using value was indeed to use it as a prop to set the radio button's value HTML attribute (rather than as Vue value binding - in such cases it should stay :value)
    • Are there some forgotten places that still need to be updated?
    • You could test manually few places with radio buttons

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob changed the title [WIP] Update KDS [WIP] Upgrade KDS from v2.0.0 to v3.0.1 on the release branch Feb 29, 2024
@github-actions github-actions bot added DEV: renderers HTML5 apps, videos, exercises, etc. APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: medium labels Feb 29, 2024
@MisRob
Copy link
Member Author

MisRob commented Feb 29, 2024

Hi @pcenov / @radinamatic, would you have a moment one more time to confirm that radio buttons at a few (any) places in Kolibri still work well? This is the same update we did some time ago here #11873, but on the release branch.

@MisRob MisRob added the TODO: needs review Waiting for review label Feb 29, 2024
@MisRob MisRob marked this pull request as ready for review February 29, 2024 09:19
@MisRob MisRob changed the title [WIP] Upgrade KDS from v2.0.0 to v3.0.1 on the release branch Upgrade KDS from v2.0.0 to v3.0.1 on the release branch Feb 29, 2024
@MisRob MisRob force-pushed the upgrade-kds branch 2 times, most recently from d026d18 to 6a1ab49 Compare February 29, 2024 09:33
Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are good, I didn't see any areas that were forgotten.

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes noticed in the pages with radio buttons, nor any other regression noted when installing assets from this PR. Tested on Ubuntu 20.04 and Windows 10 (Firefox and Chrome). Good to go! 💯 👍🏽 :shipit:

@rtibbles rtibbles added this to the Kolibri 0.16: Planned Patch 1 milestone Mar 1, 2024
@rtibbles rtibbles merged commit 33e4c76 into learningequality:release-v0.16.x Mar 1, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend DEV: renderers HTML5 apps, videos, exercises, etc. SIZE: medium SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants