Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FacilityUser instead of AUTH_USER_MODEL in migrations #11984

Merged

Conversation

jredrejo
Copy link
Member

Summary

Using settings.AUTH_USER_MODEL breaks migrations when using kolibri in context where this model points to something different than FacilityUser. For example, PortalUser in KDP

References

For the future, any time migrations are created that relate to the user model, we should ensure that they point to FacilityUser. When changing AUTH_USER_MODEL, we may not want the kolibri models to be used for this new user type.

Reviewer guidance

Migrations should continue working fine

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added TODO: needs review Waiting for review bug Behavior is wrong or broken labels Mar 13, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Mar 13, 2024
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me. My only worry is whether this will affect Kolibri upgrades when its released. I assume this will cause some pain to rollout on KDP?

@jredrejo
Copy link
Member Author

The changes make sense to me. My only worry is whether this will affect Kolibri upgrades when its released. I assume this will cause some pain to rollout on KDP?

probably, we'll test it in staging when the new kolibri release comes

@jredrejo jredrejo merged commit 4959560 into learningequality:release-v0.16.x Mar 13, 2024
34 checks passed
@jredrejo jredrejo deleted the do_not_use_AUTH_USER_MODEL branch March 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behavior is wrong or broken DEV: backend Python, databases, networking, filesystem... SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants