Added another condition for TOPICS_TOPIC_SEARCH redirection

[Wck-iipi]

Summary

User can now see content instead of search bar. Also, I changed the not some not condition logic to every condition logic(they are equivalent to each other) because it is easier to read.

References

Fixes #11842

Reviewer guidance

I have tested this with nested empty folders as well and this works on them too. However, I haven't tested them on completely empty folders with no content as I couldn't find such channel(or make one).

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.1a0.dev0_git.21.ga30fa90b.pex
Windows Installer (EXE)	kolibri-0.16.1a0.dev0+git.21.ga30fa90b-windows-setup-unsigned.exe
Debian Package	kolibri_0.16.1a0.dev0+git.21.ga30fa90b-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.1a0.dev0+git.21.ga30fa90b-0.4.0.dmg
Android Package (APK)	kolibri-0.16.1a0.dev0+git.21.ga30fa90b-0.1.1-debug.apk
TAR file	kolibri-0.16.1a0.dev0+git.21.ga30fa90b.tar.gz
WHL file	kolibri-0.16.1a0.dev0+git.21.ga30fa90b-py2.py3-none-any.whl

[MisRob]

Thansk @Wck-iipi, we will have a look

[pcenov]

Hi @Wck-iipi, thank you for your contribution. While manually testing I noticed that you have only fixed the issue with the expanded filter but the issue with the expanded folders list is still extant and should be fixed as well. Once I select a folder, then I should first see the contents of the folder and then decide whether to further explore the contents of another folder:

2024-04-18_13-37-17.mp4

[Wck-iipi]

@pcenov I have fixed it. Please check if it is working correctly now.

[pcenov]

Thanks a lot @Wck-iipi - confirm that the filters are functioning correctly now!

[marcellamaki]

Hi @Wck-iipi - thank you for your work on this, and I'm sorry for the delay in code review!

Overall, it seems like the functionality is working as expected based on @pcenov 's review, so thank you. I do have one question about the conditional check you added. Thank you!

[marcellamaki]

Could you explain the nested if statements here? I understand the first part as the refactor, and I agree that it keeps the condition and makes it easier to read, so thank you. The second one, I'm hoping you could explain why you made this change. Is it to account for empty folders that you mention in the description? If so, I do think having a condition to manage this is a good idea, but I wonder if there might be something a bit easier to logic through than checking by the c.title. Were there other solutions or ideas that you had when thinking through this?

Still outstanding questions on the code review, so dismissing this until they are resolved.