Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds modal before delete section #12101

Merged
merged 2 commits into from May 1, 2024

Conversation

akolson
Copy link
Member

@akolson akolson commented Apr 23, 2024

Summary

This PR updates the the "Options > Delete" action in "Create new quiz" to display a delete confirmation modal prior to deleting the section

Screen.Recording.2024-04-23.at.10.35.51.mov

References

Fixes #12064

Reviewer guidance

  1. Create a new quiz
  2. Add a new section
  3. Delete the section using "Options > Delete"

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson added the TODO: needs review Waiting for review label Apr 23, 2024
@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Apr 23, 2024
@akolson akolson marked this pull request as ready for review April 23, 2024 19:57
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally & code looks good. Thanks for this Samson!

@akolson
Copy link
Member Author

akolson commented Apr 30, 2024

@AllanOXDi any more thoughts?

@AllanOXDi
Copy link
Member

LGTM

@akolson akolson merged commit 7368f26 into learningequality:develop May 1, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small TODO: needs review Waiting for review
Projects
None yet
3 participants