Fix Vue Tesing Library routes bug #12105
Conversation
github-actions
bot
added
DEV: frontend
DEV: tools
Build Artifacts
|
jest.conf.js
Outdated
| @@ -12,4 +12,6 @@ module.exports = Object.assign(baseConfig, { | |||
| 'packages/hashi/src/*.js', | |||
| 'packages/kolibri-tools/lib/src/*.js', | |||
| ], | |||
| maxConcurrency: 2, | |||
There was a problem hiding this comment.
What is the reason for this? If the tests are having issues being parallelized, that tends to indicate there's an issue in the tests themselves (this only affects running on developer machines, as in a CI environment, Jest automatically runs tests sequentially instead).
There was a problem hiding this comment.
Noooo I thought I deleted it, Im sorry. I changed it bc it was taking all my processors and my computer died trying to run the tests.
There was a problem hiding this comment.
No worries - I did wonder if that was the case!
In future, you can also just pass additional jest CLI options: https://jestjs.io/docs/cli#--maxconcurrencynum for maxConcurrency and maxWorkers to the test invocation in Kolibri, it should pass through the additional arguments.
There was a problem hiding this comment.
Yes, for some reason I thought CLI options wasn't working but I think it was because I was passing maxConcurrency instead of maxWorkers. Thanks!
There was a problem hiding this comment.
Good to know, I had to do a bit of work to make sure our thin wrapper around jest passed through the additional CLI arguments, so I am glad that's still working!
AlexVelezLl
force-pushed
the
fix-vtl-routing-bugs
branch
from
940b23b
to
3e30d2c
Compare
jest.conf.js
Outdated
| @@ -12,4 +12,6 @@ module.exports = Object.assign(baseConfig, { | |||
| 'packages/hashi/src/*.js', | |||
| 'packages/kolibri-tools/lib/src/*.js', | |||
| ], | |||
| maxConcurrency: 2, | |||
There was a problem hiding this comment.
No worries - I did wonder if that was the case!
In future, you can also just pass additional jest CLI options: https://jestjs.io/docs/cli#--maxconcurrencynum for maxConcurrency and maxWorkers to the test invocation in Kolibri, it should pass through the additional arguments.
|
Thank you @rtibbles! |
Summary
For now there is a bug when we use the render function of Vue testing library without passing a
routesprop, this has forced us to import VueRouter, and pass aroutes: new VueRouter()prop just to avoid this error, although we don't use it. This means that we have more boilerplate code even for the simplest tests.This error raises because for some reason vue router in its inner implementation checks if the
$option.routerobject is defined, but just checking forundefinedvalues, so when this value is null, it gives a null pointer exception.Reviewer guidance
Check that VTL tests run successfully even if we dont pass the
routesprop.Testing checklist
PR process
Reviewer checklist
yarnandpip)