Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logos and installer branding #12124

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented May 1, 2024

Summary

  • Updates logos
  • Updates all installers to rebranded installers

Reviewer guidance

Check all logos to ensure that they are properly updated


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the Kolibri 0.16: Planned Patch 2 milestone May 1, 2024
@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment DEV: backend Python, databases, networking, filesystem... APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: very large labels May 1, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. code review cross-referenced installer update release version numbers as well as logo changes. expected behavior in mac ports confirmed in manual QA. smoke testing of local dev, pex, and macOS (including installer-related logo updates) all check out.

once checks pass should be good to go

@marcellamaki marcellamaki merged commit 86a5d19 into learningequality:release-v0.16.x May 1, 2024
34 checks passed
@rtibbles rtibbles deleted the non_svg_logos branch May 1, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment DEV: frontend SIZE: very large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants