Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App script cleanup #12155

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Use namespaced logging for the app script
  • Cleanup unnecessary and uninformative logging

References

Was investigating if #11985 was still extant, it doesn't appear to be.

Reviewer guidance

Nothing ground breaking here, but useful cleanup.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels May 10, 2024
@rtibbles rtibbles changed the base branch from release-v0.16.x to develop June 4, 2024 19:18
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here all LGTM. Be this my severalth reminder that we can create namespaced loggers :)

@rtibbles rtibbles merged commit 3113959 into learningequality:develop Jun 12, 2024
31 checks passed
@rtibbles rtibbles deleted the metered_not_yarded branch June 12, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants