EQM: On first save, update the quiz's ID when redirecting #12283
Conversation
github-actions
bot
added
APP: Coach
Build Artifacts
|
| this.$router.replace({ | ||
| name: PageNames.EXAM_CREATION_ROOT, | ||
| params: { | ||
| classId: this.$route.params.classId, | ||
| quizId: exam.id, | ||
| }, | ||
| }); | ||
| // Update the quiz with the new id - there won't be if this is a new quiz, | ||
| // this ensures the quiz is kept up-to-date since we're replacing the route | ||
| this.updateQuiz({ id: exam.id }); |
There was a problem hiding this comment.
This seems right - although maybe this should live inside the useQuizCreation composable?
There was a problem hiding this comment.
I tried putting it at the end of saveQuiz but it wasn't working so I tried this... I think that maybe the issue was that I wasn't returning the exam in the then callback on the ExamResource.saveModel -- I've pushed an update that seems to work better there.
| @@ -174,16 +174,16 @@ | |||
| }, | |||
| }); | |||
| } else { | |||
| if (this.$route.params.quizId === exam.id) { | |||
There was a problem hiding this comment.
I don't think we should remove this - but we should coerce them both to strings for the comparison because for draft exams the exam.id will be an integer, but the route parameter will be a string.
When I did a subsequent save, not having this here led me to get a redundant navigation error from the replace below.
| @@ -323,7 +323,12 @@ export default function useQuizCreation() { | |||
| finalQuiz.question_sources = questionSourcesWithoutResourcePool; | |||
| } | |||
|
|
|||
| return ExamResource.saveModel({ id, data: finalQuiz }); | |||
| return ExamResource.saveModel({ id, data: finalQuiz }).then(exam => { | |||
| if (!get(_quiz).id) { | |||
There was a problem hiding this comment.
Should this maybe be if (!id || id !== exam.id) {
id here being assigned to the get(_quiz).id up above.
There was a problem hiding this comment.
Presumably if id is undefined then it won't equal exam.id either, so the falsy check might be redundant.
But yeah, using the id that we already grabbed in the outer scope feels safer, just in case we're accidentally mutating state for some reason.
There was a problem hiding this comment.
Okay cool - I was getting mixed up a bit around the use of "new" for the route until they save the quiz but get(_quiz).id will always be null/undefined here eh?
nucleogenesis
force-pushed
the
fix--eqm-can-save-and-save-and-close
branch
from
2e4ce17
to
7f4614c
Compare
Summary
Fixes #12263
When the
newquiz is saved, since we replace the route, we need to also update the ID of the quiz so that subsequent saves are updating the quiz rather than trying to save the same quiz anew.Reviewer guidance