i18n additions in support of Perseus i18nization #1869

rtibbles · 2017-07-19T22:23:24Z

Summary

Most of these changes are build related that I have put in, so that the i18nization of the perseus render is made possible.

Also adds the interactive prop which allows signalling that an otherwise interactive content item should be rendered uninteractively.

Note that this now also includes an upgrade for the perseus renderer, with the following diff: learningequality/kolibri-exercise-perseus-plugin@v0.6.16...v0.7.0

codecov-io · 2017-07-19T22:45:57Z

Codecov Report

Merging #1869 into develop will increase coverage by 0.21%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           develop   #1869      +/-   ##
==========================================
+ Coverage    76.89%   77.1%   +0.21%     
==========================================
  Files          170     170              
  Lines         6228    6259      +31     
  Branches       791     796       +5     
==========================================
+ Hits          4789    4826      +37     
+ Misses        1295    1289       -6     
  Partials       144     144

Impacted Files	Coverage Δ
frontend_build/src/parse_bundle_plugin.js	`89.65% <ø> (ø)`	⬆️
frontend_build/src/webpack.config.base.js	`76.19% <ø> (-2.98%)`	⬇️
kolibri/content/hooks.py	`53.12% <0%> (ø)`	⬆️
kolibri/content/serializers.py	`84.24% <100%> (+1.23%)`	⬆️
kolibri/content/api.py	`56.81% <100%> (+4.84%)`	⬆️
kolibri/core/templatetags/kolibri_tags.py	`39.47% <100%> (ø)`	⬆️
frontend_build/src/read_bundle_plugins.js	`90.27% <61.53%> (-6.39%)`	⬇️
frontend_build/src/extract_$trs.js	`13.38% <0%> (-0.1%)`	⬇️
kolibri/tasks/api.py	`32.79% <0%> (+0.26%)`	⬆️
kolibri/content/models.py	`93.6% <0%> (+0.43%)`	⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed7c59...ab842b8. Read the comment docs.

…bundles.

rtl or ltr css depending on the directionality of its content.

for example for displaying student answers in coach reports.

Allow plugins to set additional node paths for custom loaders used in their build.

…ck2. Add the LoaderOptionsPlugin that ensures that output of loaders is minified.

content Language model. Add support for contentnode language data.

indirectlylit

still testing. Looks good; just sharing initial comments on the code itself

frontend_build/src/read_bundle_plugins.js

  // We add some custom configuration options to the bundles that webpack 2 dislikes, clean them up here.
  bundles.forEach(function(bundle) {
    delete bundle.core_name;
    delete bundle.coreAPISpec;
+    if (bundle.nodePaths) {


kolibri/core/assets/src/core-app/mediator.js

+          url =>
+            (languageDirection === languageDirections.RTL &&
+              url.includes(languageDirections.RTL)) ||
+            !url.includes('css')


kolibri/core/assets/src/core-app/mediator.js

+          (direction !== languageDirections.RTL && url.includes(languageDirections.RTL)) ||
+          (direction !== languageDirections.LTR &&
+            !url.includes(languageDirections.RTL) &&
+            url.includes('css'))


kolibri/core/assets/src/core-app/mediator.js

+              module.urlTags = {};
+              urls.forEach((url, index) => {
+                module.urlTags[url] = scriptsArray[index];
+              });


kolibri/core/assets/src/views/content-renderer/index.vue

+      interactive: {
+        type: Boolean,
+        default: true,
+      },


indirectlylit

This all seems to work for me.

I did notice that perseus now seems hard-coded to reference kolibri v0.6 on crowdin which gave me pause. I wouldn't mind learning a bit more about the way that translations between these two projects are intertwined.

rtibbles · 2017-08-31T00:49:52Z

We could make a new project for the perseus plugin which would clean this up for the future.

rtibbles added this to the 0.6.0 milestone Jul 19, 2017

rtibbles requested a review from indirectlylit July 19, 2017 22:23

rtibbles mentioned this pull request Jul 19, 2017

Internationalization of Perseus Renderer learningequality/kolibri-exercise-perseus-plugin#99

Merged

rtibbles force-pushed the i18n_redux branch 2 times, most recently from fb18ded to f58af4d Compare August 28, 2017 16:42

rtibbles added the TODO: needs review Waiting for review label Aug 28, 2017

rtibbles added 8 commits August 28, 2017 17:00

Ensure code split chunks are named to prevent name collisions across …

90b7020

…bundles.

Add infrastructure to allow a content renderer to independently load

51f340f

rtl or ltr css depending on the directionality of its content.

Allow content renderers to be flagged as not interactive,

724cfa9

for example for displaying student answers in coach reports.

Allow plugins to add their own aliases for their build.

0f531eb

Allow plugins to set additional node paths for custom loaders used in their build.

Remove the OccurrenceOrderPlugin that is no longer necessary in Webpa…

5e88035

…ck2. Add the LoaderOptionsPlugin that ensures that output of loaders is minified.

Update frontend language code to follow same schema as

868a241

content Language model. Add support for contentnode language data.

Properly invoke super method.

af9d0aa

Update perseus renderer.

78bc43a

rtibbles force-pushed the i18n_redux branch from f58af4d to 78bc43a Compare August 29, 2017 00:03

indirectlylit reviewed Aug 29, 2017

View reviewed changes

Use endsWith. Add more code comments.

ab842b8

rtibbles changed the base branch from develop to release-v0.6.x August 30, 2017 20:01

indirectlylit approved these changes Aug 31, 2017

View reviewed changes

indirectlylit merged commit 5811bd1 into learningequality:release-v0.6.x Aug 31, 2017

indirectlylit removed the TODO: needs review Waiting for review label Aug 31, 2017

rtibbles mentioned this pull request Sep 14, 2017

Extra bullet points appear on the answer options when the question is accessed through a tablet. #2177

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

i18n additions in support of Perseus i18nization #1869

i18n additions in support of Perseus i18nization #1869

rtibbles commented Jul 19, 2017 •

edited

Loading

codecov-io commented Jul 19, 2017 •

edited

Loading

indirectlylit left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

indirectlylit left a comment

rtibbles commented Aug 31, 2017

i18n additions in support of Perseus i18nization #1869

i18n additions in support of Perseus i18nization #1869

Conversation

rtibbles commented Jul 19, 2017 • edited Loading

Summary

codecov-io commented Jul 19, 2017 • edited Loading

Codecov Report

indirectlylit left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

indirectlylit left a comment

Choose a reason for hiding this comment

rtibbles commented Aug 31, 2017

rtibbles commented Jul 19, 2017 •

edited

Loading

codecov-io commented Jul 19, 2017 •

edited

Loading