Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CherryPy to 13.0.1 after namespacing issue was resolved #2976

Merged
merged 1 commit into from Dec 18, 2017

Conversation

benjaoming
Copy link
Contributor

Summary

Back on track with upstream CherryPy after namespaced packages has temporarily been accepted as a blocker.

Will have to work on pip install <...> -t <...> to resolve how we avoid similar errors in the future. Possibly upstream.

Reviewer guidance

None, I think we're safe -- will give it a manual test spin.

References

#2972
cherrypy/cherrypy#1671


Contributor Checklist

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • Contributor has fully tested the PR manually
  • Screenshots of any front-end changes are in the PR description
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')

Reviewer Checklist

  • Automated test coverage is satisfactory
  • Reviewer has fully tested the PR manually
  • PR has been tested for accessibility regressions
  • External dependencies files were updated (yarn and pip)
  • Documentation is updated
  • Link to diff of internal dependency change is included
  • CHANGELOG.rst is updated for high-level changes
  • Contributor is in AUTHORS.rst

@benjaoming benjaoming added TODO: needs gherkin update Add to our manual integration tests DEV: distributions Windows, Debian, PyPi, whl files, etc labels Dec 17, 2017
@benjaoming benjaoming added this to the 0.8.0 milestone Dec 17, 2017
@benjaoming benjaoming self-assigned this Dec 17, 2017
@codecov
Copy link

codecov bot commented Dec 17, 2017

Codecov Report

Merging #2976 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2976   +/-   ##
========================================
  Coverage    76.09%   76.09%           
========================================
  Files          187      187           
  Lines         7283     7283           
  Branches       915      915           
========================================
  Hits          5542     5542           
  Misses        1562     1562           
  Partials       179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3af32d...581c743. Read the comment docs.

Copy link
Contributor

@lyw07 lyw07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu 14.04, 16.04, 17.10 and Mac OS X. Looks good to me!

@lyw07 lyw07 merged commit 07944e5 into learningequality:develop Dec 18, 2017
@benjaoming benjaoming deleted the feature/cherrypy-upgrade branch December 18, 2017 14:47
@radinamatic radinamatic removed the TODO: needs gherkin update Add to our manual integration tests label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: distributions Windows, Debian, PyPi, whl files, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants