Add Auto-saving and Search to Lesson Resource Selection #4253
Conversation
|
To quote @navakk9: "BEST NEWS EVER!" - this is great! I know it may not be possible in the scope of the time available to get this in, but would be good to think about how we can try to reduce code duplication for search once we have also implemented this for exams (and also with the core search functionality too). The other question is about the filtering and pagination - the filtering is now dependent on the displayed results, which can hide relevant filter options if there are more results than the default page size. There's also no option to paginate. The search results include metadata that can be used here, the core search functionality implements these, for reference. |
jonboiser
force-pushed
the
lessons-updates
branch
from
75dbbf6
to
3db59a0
Compare
jonboiser
force-pushed
the
lessons-updates
branch
from
c68daa0
to
96fef6b
Compare
kolibri/plugins/coach/assets/src/views/assignments/AssignmentSummary.vue
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/exams/CreateExamPage/index.vue
Outdated
Show resolved
Hide resolved
.../coach/assets/src/views/lessons/LessonResourceSelectionPage/SearchTools/LessonsSearchBox.vue
Outdated
Show resolved
Hide resolved
| :contentHasCheckbox="contentIsDirectoryKind" | ||
| :contentCardMessage="selectionMetadata" | ||
| :contentCardLink="contentLink" | ||
| @change_select_all="toggleTopicInWorkingResources" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## develop #4253 +/- ##
===========================================
- Coverage 53.2% 53.13% -0.08%
===========================================
Files 693 697 +4
Lines 22046 22158 +112
Branches 2985 3007 +22
===========================================
+ Hits 11729 11773 +44
- Misses 9622 9685 +63
- Partials 695 700 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4253 +/- ##
===========================================
+ Coverage 53.2% 53.21% +0.01%
===========================================
Files 693 699 +6
Lines 22046 22255 +209
Branches 2985 3024 +39
===========================================
+ Hits 11729 11843 +114
- Misses 9622 9710 +88
- Partials 695 702 +7
Continue to review full report at Codecov.
|
5 similar comments
Codecov Report
@@ Coverage Diff @@
## develop #4253 +/- ##
===========================================
+ Coverage 53.2% 53.21% +0.01%
===========================================
Files 693 699 +6
Lines 22046 22255 +209
Branches 2985 3024 +39
===========================================
+ Hits 11729 11843 +114
- Misses 9622 9710 +88
- Partials 695 702 +7
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4253 +/- ##
===========================================
+ Coverage 53.2% 53.21% +0.01%
===========================================
Files 693 699 +6
Lines 22046 22255 +209
Branches 2985 3024 +39
===========================================
+ Hits 11729 11843 +114
- Misses 9622 9710 +88
- Partials 695 702 +7
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4253 +/- ##
===========================================
+ Coverage 53.2% 53.21% +0.01%
===========================================
Files 693 699 +6
Lines 22046 22255 +209
Branches 2985 3024 +39
===========================================
+ Hits 11729 11843 +114
- Misses 9622 9710 +88
- Partials 695 702 +7
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4253 +/- ##
===========================================
+ Coverage 53.2% 53.21% +0.01%
===========================================
Files 693 699 +6
Lines 22046 22255 +209
Branches 2985 3024 +39
===========================================
+ Hits 11729 11843 +114
- Misses 9622 9710 +88
- Partials 695 702 +7
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4253 +/- ##
===========================================
+ Coverage 53.2% 53.21% +0.01%
===========================================
Files 693 699 +6
Lines 22046 22255 +209
Branches 2985 3024 +39
===========================================
+ Hits 11729 11843 +114
- Misses 9622 9710 +88
- Partials 695 702 +7
Continue to review full report at Codecov.
|
integration_testing/features/admin/admin-change-facility-settings.feature
Show resolved
Hide resolved
There was a problem hiding this comment.
Notes
This button should say 'Manage resources':
'Total resources selected: 2' is confusing with auto-save. Recommend changing to '2 resources in lesson' or similar
Similarly here:
Instead of 'Undo', recommend this link says 'Remove' because it could have happened a long time ago
.../coach/assets/src/views/lessons/LessonResourceSelectionPage/SearchTools/LessonsSearchBox.vue
Outdated
Show resolved
Hide resolved
| // Map of { kind, channel, role } | ||
| type: Object, | ||
| required: true, | ||
| }, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| getParams: { | ||
| search: params.searchTerm, | ||
| }, | ||
| }).then(results => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| }, | ||
| }).then(results => { | ||
| return showResourceSelectionPage(store, { | ||
| classId: params.classId, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
indirectlylit
dismissed
their stale review
dismissing review until pagination changes are addressed
indirectlylit
added
changelog
Summary
Search
Autosave
Create Exam Page
Reviewer guidance
Testing search
Testing auto save
References
…
Contributor Checklist
Reviewer Checklist
yarnandpip)