Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update front end docs (WIP) #4520

Merged
merged 3 commits into from Nov 10, 2018
Merged

Update front end docs (WIP) #4520

merged 3 commits into from Nov 10, 2018

Conversation

christianmemije
Copy link
Contributor

Summary

Update front end docs (WIP)

References


Contributor Checklist

  • Contributor has fully tested the PR manually
  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If there are any front-end changes, before/after screenshots are included
  • If this is an important user-facing change, PR or related issue has a 'changelog' label

Reviewer Checklist

  • Automated test coverage is satisfactory
  • Reviewer has fully tested the PR manually
  • PR has been tested for accessibility regressions
  • External dependencies files were updated (yarn and pip)
  • Documentation is updated
  • Link to diff of internal dependency change is included
  • CHANGELOG.rst is updated for high-level changes
  • Contributor is in AUTHORS.rst

@christianmemije christianmemije added the work-in-progress Not ready for review label Nov 6, 2018
Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

app.js # instantiate mgmt app on client-side
views/UserPage.vue # nested-view
views/ManagementIndex.vue # root view
app.js # instantiate mgmt app on client-side
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the most significant change since this was first written is how we deal with vuex - would you mind adding that?

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #4520 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #4520   +/-   ##
=======================================
  Coverage     51.9%   51.9%           
=======================================
  Files          735     735           
  Lines        24317   24317           
  Branches      3304    3304           
=======================================
  Hits         12622   12622           
  Misses       10927   10927           
  Partials       768     768

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0f2f1...d800deb. Read the comment docs.

@jonboiser jonboiser merged commit 37f7d61 into learningequality:develop Nov 10, 2018
@christianmemije
Copy link
Contributor Author

My last PR merged! 🎉 🍾

@indirectlylit indirectlylit mentioned this pull request Nov 20, 2018
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants