Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling updates #4909

Merged
merged 9 commits into from Feb 4, 2019
Merged

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Feb 4, 2019

Summary

Consistent 'empty value' placeholder across all tables with gray text and an em-dash:

before after
image image

New containers are now a core, responsive component and applied to Coach, Facilty, and Device:

before after
image image

top-nav tab styling updates:

before after
image image

Coach inner-tab styling updates:

before after
image image

Reviewer guidance

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Gherkin stories have been updated
  • Unit tests have been updated

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.rst

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #4909 into develop will increase coverage by 25.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #4909       +/-   ##
============================================
+ Coverage    50.77%   76.01%   +25.23%     
============================================
  Files          871      254      -617     
  Lines        26932    11831    -15101     
  Branches      3583     1420     -2163     
============================================
- Hits         13675     8993     -4682     
+ Misses       12488     2515     -9973     
+ Partials       769      323      -446
Impacted Files Coverage Δ
kolibri/utils/uuids.py 22.22% <0%> (-14.4%) ⬇️
kolibri/core/apps.py 91.3% <0%> (-8.7%) ⬇️
kolibri/core/content/test/sqlalchemytesting.py 84% <0%> (-8%) ⬇️
kolibri/utils/env.py 87.5% <0%> (-6.25%) ⬇️
kolibri/core/deviceadmin/utils.py 93.58% <0%> (-5.13%) ⬇️
kolibri/core/notifications/models.py 87.5% <0%> (-4.17%) ⬇️
kolibri/utils/cli.py 66.54% <0%> (-3.53%) ⬇️
kolibri/utils/conf.py 80.7% <0%> (-3.51%) ⬇️
...olibri/core/content/utils/import_export_content.py 83.33% <0%> (-2.09%) ⬇️
kolibri/core/device/api.py 95.77% <0%> (-1.41%) ⬇️
... and 567 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1d709...0126aa7. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #4909 into develop will decrease coverage by 0.07%.
The diff coverage is 21.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #4909      +/-   ##
==========================================
- Coverage    50.77%   50.7%   -0.08%     
==========================================
  Files          871     874       +3     
  Lines        26932   26953      +21     
  Branches      3583    3583              
==========================================
- Hits         13675   13666       -9     
- Misses       12488   12518      +30     
  Partials       769     769
Impacted Files Coverage Δ
...ets/src/views/reports/ReportsLessonLearnerPage.vue 0% <ø> (ø) ⬆️
...portsGroupReportLessonExerciseQuestionListPage.vue 0% <ø> (ø) ⬆️
...gins/coach/assets/src/views/CoachClassListPage.vue 0% <ø> (ø) ⬆️
.../reports/ReportsGroupReportQuizLearnerListPage.vue 0% <ø> (ø) ⬆️
...src/views/reports/ReportsLessonLearnerListPage.vue 0% <ø> (ø) ⬆️
...ins/coach/assets/src/views/home/HomePage/index.vue 0% <ø> (ø) ⬆️
.../reports/ReportsLessonExerciseQuestionListPage.vue 0% <ø> (ø) ⬆️
...ets/src/views/reports/ReportsLearnerReportPage.vue 0% <ø> (ø) ⬆️
...assets/src/views/reports/ReportsQuizEditorPage.vue 0% <ø> (ø) ⬆️
...sets/src/views/reports/ReportsLessonEditorPage.vue 0% <ø> (ø) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1d709...4d2d510. Read the comment docs.

@indirectlylit indirectlylit added this to the 0.12.0 milestone Feb 4, 2019
@indirectlylit indirectlylit added the TODO: needs review Waiting for review label Feb 4, 2019
@indirectlylit indirectlylit merged commit 9afa223 into learningequality:develop Feb 4, 2019
@indirectlylit indirectlylit deleted the styling branch February 4, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants