-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gestures on PDFs #6996
Merged
indirectlylit
merged 2 commits into
learningequality:app-support
from
nucleogenesis:mobile-gestures
Jun 17, 2020
Merged
Gestures on PDFs #6996
indirectlylit
merged 2 commits into
learningequality:app-support
from
nucleogenesis:mobile-gestures
Jun 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
@mrpau-dev would you mind testing this on Android? |
kolibri/plugins/pdf_viewer/assets/src/views/PdfRendererIndex.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/pdf_viewer/assets/src/views/PdfRendererIndex.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Devon Rueckner <indirectlylit@users.noreply.github.com>
@indirectlylit I'm having the same issue with the installer built in this PR. The Kolibri Android app crashes after I launch it. |
merging to get it in place for integration testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds hammerjs and in PDF Renderer make use of it to handle pinch-zoom gestures on mobile.
Does not work on iOS because Apple's pinch zooming always zooms the whole window without regard for any kind of meta viewport settings (ie,
maximum-scale
oruser-scalable
).However, it works on Android.
Basically, a pinch will call the same
zoomIn
orzoomOut
function as tapping the + and - buttons do. They're throttled to 1 second to avoid accidentally zooming all the way in with one pinch.NOTE: Not tested in a real life proper "app context" running the Android app - but still a valuable addition for non-app users who do use android devices anyway.
Reviewer guidance
Open a PDF using an Android device and pinch zoom in and out.
Testing this without an actual device is a pain - but if you use Genymotion read this (it wasn't perfect for me, but good enough early on)
References
#3710
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)