Scorm hashi bugs #7001
Scorm hashi bugs #7001
Conversation
Codecov Report
|
| const lessonStatus = this.data.cmi.core.lesson_status; | ||
| if (statusProgressMap.hasOwnProperty(lessonStatus)) { | ||
| const lessonStatus = getByKeyPath(this.data, 'cmi.core.lesson_status', SCHEMA, self.userData); | ||
| if (Object.prototype.hasOwnProperty.call(statusProgressMap, lessonStatus)) { |
There was a problem hiding this comment.
Just curious about why this change was made. e.g. how Object.prototype.hasOwnProperty.call differs in behavior from statusProgressMap.hasOwnProperty. Is this to handle the case where lessonStatus is undefined? If so, any reason not to check it for undefined first?
There was a problem hiding this comment.
This was flagged by our linter which has this rule: https://eslint.org/docs/rules/no-prototype-builtins
I made the same change the last time I merged pf-mvp -> develop
There was a problem hiding this comment.
Yeah - I originally made this change on develop, so @indirectlylit's linting fix was caught up in my stash. It seemed simpler to retain this change than to undo it when I reapplied it to pf-mvp.
|
Also, since pf-mvp changes have been merged to develop, we need to make sure we apply this fix there as well. |
Summary
Fixes two small issues that I noticed while using hashi after the SCORM updates:
Reviewer guidance
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarnandpip)