Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub strings for potential tweaks to login flow #7053

Merged

Conversation

indirectlylit
Copy link
Contributor

Summary

adding a few strings that might be helpful in updates to the login flow

Reviewer guidance

does it pass?

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@indirectlylit indirectlylit changed the base branch from develop to release-v0.14.x June 12, 2020 21:56
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #7053 into release-v0.14.x will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
...plugins/facility/assets/src/views/CsvInfoModal.vue 0.00% <ø> (ø)
...libri/plugins/user/assets/src/views/SignInPage.vue 34.59% <ø> (ø)

@indirectlylit
Copy link
Contributor Author

self merge - unrelated failure

@indirectlylit indirectlylit merged commit 30e9d1e into learningequality:release-v0.14.x Jun 16, 2020
@indirectlylit indirectlylit deleted the stub-strings branch June 16, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant