Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around ICT routes sizing bug by expanding HTML5 canvas size… #7054

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

kollivier
Copy link
Contributor

@kollivier kollivier commented Jun 12, 2020

… and overall page width.

Summary

There is some issue with the scaling approach taken by some of the new SCORM content, so as a short-term workaround, expand the page width and HTML5 iframe height and width by a modest amount in order to be large enough to not trigger the scaling.

Reviewer guidance

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@kollivier kollivier self-assigned this Jun 12, 2020
@kollivier kollivier added the TODO: needs review Waiting for review label Jun 12, 2020
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #7054 into pf-mvp will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
kolibri/core/assets/src/views/CoreBase/index.vue 46.61% <ø> (ø)
..._viewer/assets/src/views/Html5AppRendererIndex.vue 0.00% <0.00%> (ø)
kolibri/plugins/profuturo_mvp/kolibri_plugin.py 93.10% <0.00%> (-6.90%) ⬇️
kolibri/core/webpack/hooks.py 56.43% <0.00%> (-1.49%) ⬇️
kolibri/plugins/profuturo_mvp/options.py 100.00% <0.00%> (ø)
kolibri/core/content/utils/channel_import.py 88.92% <0.00%> (+0.56%) ⬆️
kolibri/core/content/utils/check_schema_db.py 100.00% <0.00%> (+8.69%) ⬆️

@indirectlylit indirectlylit merged commit 0ac7bd5 into learningequality:pf-mvp Jun 12, 2020
indirectlylit added a commit to indirectlylit/kolibri that referenced this pull request Jun 16, 2020
@indirectlylit indirectlylit mentioned this pull request Jun 16, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants