Update Python version at the build_windows dockerfile

[mrpau-richard]

Summary

I updated the Python version at the windows build dockerfile

Reviewer guidance

Test the Windows installer built in this PR from the BuildKite.

References

…

---

Contributor Checklist

PR process:

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Testing:

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

Reviewer Checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[codecov]

Codecov Report

Merging #7072 into release-v0.14.x will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
kolibri/plugins/user/assets/src/views/AuthBase.vue	51.35% <0.00%> (-7.27%)	⬇️
kolibri/core/device/hooks.py	83.33% <0.00%> (-6.67%)	⬇️
kolibri/core/content/serializers.py	90.05% <0.00%> (-3.89%)	⬇️
kolibri/core/device/middleware.py	92.68% <0.00%> (-3.87%)	⬇️
kolibri/core/tasks/utils.py	89.65% <0.00%> (-3.45%)	⬇️
kolibri/core/assets/src/core-app/client.js	12.24% <0.00%> (-2.76%)	⬇️
kolibri/core/device/permissions.py	80.76% <0.00%> (-1.84%)	⬇️
...libri/core/auth/management/commands/deprovision.py	91.89% <0.00%> (-1.29%)	⬇️
kolibri/core/content/models.py	87.50% <0.00%> (-1.23%)	⬇️
kolibri/core/auth/api.py	87.81% <0.00%> (-0.48%)	⬇️
... and 35 more

[cpauya]

Looking good so far! Will review a while then approve this to get it merged.

[cpauya]

@mrpau-richard Can you take a look why it's still extracting python-setup\python-3.4.3.msi?

[cpauya]

Python 3.4.3 packages are still included in the installer.

Let's remove them @mrpau-richard and this is good to go! 😸

[cpauya]

Can you also update this Makefile? https://github.com/learningequality/kolibri-installer-windows/blob/v1.4.0-beta1/src/Makefile#L2 - I assume it's the one downloading those python-3.4.3.* files.

[mrpau-richard]

Can you also update this Makefile? https://github.com/learningequality/kolibri-installer-windows/blob/v1.4.0-beta1/src/Makefile#L2 - I assume it's the one downloading those python-3.4.3.* files.

Thanks @cpauya , I'll create another beta release for that changes in the Windows installer repo.

[cpauya]

For Reference, this fixes this issue: learningequality/kolibri-installer-windows#171

[cpauya]

Can you also update this Makefile? https://github.com/learningequality/kolibri-installer-windows/blob/v1.4.0-beta1/src/Makefile#L2 - I assume it's the one downloading those python-3.4.3.* files.

Thanks @cpauya , I'll create another beta release for that changes in the Windows installer repo.

Nope, it should be changed in this PR to prevent downloading python packages twice.

That Makefile is being called via the make command here https://github.com/learningequality/kolibri/pull/7072/files#diff-6a804582ce0ce188519a48b7721c5da9R37 - It's the script downloading those python-3.4.3.* files as per BuildKite logs: https://buildkite.com/learningequality/kolibri-python-package/builds/1131#93e2bb69-0530-4703-bc9b-111af5e5173a/163-220

And then the curl command gets called next which downloads the python-3.6.8.* files.

I think doing either of this will work fine:

1. You can make the changes to python-3.6.8 in the Makefile and remove the curl commands;
2. Comment-out (let's not remove them yet) the wget commands in the Makefile.

Please check.

[cpauya]

Ah, I see you already made changes at https://github.com/learningequality/kolibri-installer-windows/pull/172/files -- please ignore my message above then. 😸

[mrpau-richard]

Ah, I see you already made changes at https://github.com/learningequality/kolibri-installer-windows/pull/172/files -- please ignore my message above then.

Yeah, I already made the v1.4.0-beta2 , Please test the next Windows installer built in this PR.

[mrpau-julius]

@mrpau-richard, @cpauya is right. We missed to change the Makefile. The python version are still in 3.4.3. It's just need to change to version 3.6.8 to make it work. Make.bat is use to local build only.

[cpauya]

@mrpau-richard You did not update the checksum values of the python-3.6.8-*.exe files - BuildKite is failing https://buildkite.com/learningequality/kolibri-python-package/builds/1132#f1c50507-48cf-4c63-85c6-1f6ec2b41674/164-1481

The checksums are here: https://www.python.org/downloads/release/python-368/

[cpauya]

The artifact on latest build at BuildKite for this PR now works! We can now merge this to get the fixes into the release-v0.14.x branch.

Thanks @mrpau-richard!

/cc: @radinamatic

[cpauya]

All good! Artifact from BuildKite tested on local Windows7 VM.

[cpauya]

And just to double-check, there's no more python-3.4.3-* files included in the package. 😸