Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the password input if the username is not correctly validated #7102

Conversation

jredrejo
Copy link
Member

@jredrejo jredrejo commented Jun 19, 2020

Summary

Password input text is not shown until the username is validated

Reviewer guidance

Pressing next without adding an username (or using an invalid username) does not show the password input screen

References

Closes #7093

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added the TODO: needs review Waiting for review label Jun 19, 2020
@jredrejo jredrejo added this to the 0.14.0 milestone Jun 19, 2020
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #7102 into release-v0.14.x will decrease coverage by 0.03%.
The diff coverage is 20.00%.

Impacted Files Coverage Δ
...libri/plugins/user/assets/src/views/SignInPage.vue 33.33% <20.00%> (-1.09%) ⬇️
kolibri/core/tasks/utils.py 89.65% <0.00%> (-3.45%) ⬇️
kolibri/core/content/utils/channel_import.py 88.48% <0.00%> (-0.57%) ⬇️
kolibri/plugins/device/assets/src/constants.js 100.00% <0.00%> (ø)
kolibri/core/assets/src/views/AppError/index.vue 68.75% <0.00%> (ø)
...i/plugins/device/assets/src/views/DeviceTopNav.vue 100.00% <0.00%> (ø)
...i/plugins/learn/assets/src/modules/search/index.js 0.00% <0.00%> (ø)
...plugins/learn/assets/src/modules/search/actions.js 0.00% <0.00%> (ø)
...ns/setup_wizard/assets/src/views/PersonalSetup.vue 0.00% <0.00%> (ø)
... and 11 more

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the issue noted below:

@@ -296,7 +296,7 @@
);
},
shouldShowPasswordForm() {
return Boolean(this.selectedListUser);
return Boolean(this.selectedListUser) && !this.usernameIsInvalid;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you click "next" before entering anything and then start typing, it transitions to the password form after 1 character because that's all it takes to make username valid.

I'd suggest also changing setSelectedListUser to not save the selectedListUser if there is no username given.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to show some user feedback that the username field is required:

2020-06-23 11 54 26

@radinamatic
Copy link
Member

It used to be there on 0.13

Selection_651

@jredrejo
Copy link
Member Author

We need to show some user feedback that the username field is required:

2020-06-23 11 54 26

@indirectlylit done. I hadn't notice the issue because pressing Enter the validation error appeared. Now it appears when clicking on the next button too.

Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jonboiser jonboiser dismissed stale reviews from indirectlylit and nucleogenesis July 1, 2020 00:30

issue was fixed

@jonboiser jonboiser merged commit eed1cf2 into learningequality:release-v0.14.x Jul 1, 2020
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants