-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show the password input if the username is not correctly validated #7102
Don't show the password input if the username is not correctly validated #7102
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the issue noted below:
@@ -296,7 +296,7 @@ | |||
); | |||
}, | |||
shouldShowPasswordForm() { | |||
return Boolean(this.selectedListUser); | |||
return Boolean(this.selectedListUser) && !this.usernameIsInvalid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you click "next" before entering anything and then start typing, it transitions to the password form after 1 character because that's all it takes to make username
valid.
I'd suggest also changing setSelectedListUser
to not save the selectedListUser
if there is no username
given.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nucleogenesis Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@indirectlylit done. I hadn't notice the issue because pressing Enter the validation error appeared. Now it appears when clicking on the next button too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
issue was fixed
Summary
Password input text is not shown until the username is validated
Reviewer guidance
Pressing next without adding an username (or using an invalid username) does not show the password input screen
References
Closes #7093
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)