Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

into -> in to #7170

Merged
merged 1 commit into from Jun 29, 2020
Merged

into -> in to #7170

merged 1 commit into from Jun 29, 2020

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Jun 24, 2020 •
edited

Summary

change string in 0.15

Reviewer guidance

look right?

References

ref: https://www.notion.so/learningequality/Login-UX-cleanup-a798ae6b755f4c859bf39020cfe47e4e

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@indirectlylit indirectlylit added TAG: user strings Application text that gets translated TODO: needs review Waiting for review labels Jun 24, 2020
@indirectlylit indirectlylit added this to the 0.15.0 milestone Jun 24, 2020
radinamatic
radinamatic approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn, you are fast... 😒
(had this opened on my side and ready to submit 😂)

@codecov
Copy link

codecov bot commented Jun 24, 2020 •
edited

Codecov Report

Merging #7170 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...libri/plugins/user/assets/src/views/SignInPage.vue 34.59% <ø> (ø)
kolibri/core/content/utils/channel_import.py 89.04% <0.00%> (+0.56%) ⬆️
kolibri/core/tasks/utils.py 93.10% <0.00%> (+3.44%) ⬆️
kolibri/core/content/utils/check_schema_db.py 100.00% <0.00%> (+8.69%) ⬆️

@jonboiser jonboiser merged commit 94ed588 into learningequality:develop Jun 29, 2020
@indirectlylit indirectlylit deleted the into branch July 8, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radinamatic radinamatic radinamatic approved these changes

@jtamiace jtamiace jtamiace approved these changes

Assignees
No one assigned
Labels
TAG: user strings Application text that gets translated TODO: needs review Waiting for review
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@indirectlylit @radinamatic @jtamiace @jonboiser