Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in Permissions pages caused by "unique username" assumption #7182

Merged

Conversation

jonboiser
Copy link
Contributor

@jonboiser jonboiser commented Jun 24, 2020

Summary

  1. Fixes bug where two users (w/ same username and different ID) would be marked as "You" and displayed incorrectly on the ManagePermissionsPage (Fixes "(you)" label on device permissions page matches on username and not ID #7130 )
  2. Fixes bug where buttons and checkboxes would be disabled on the UserPermissionsPage if the user being viewed has the same username (but different user ID). Fixes cannot elevate user in another facility to super admin #7159
  3. Adds optimization to ManagePermissionsPage to use a memoized function to display the Facility name on the table, which will reduce computations for large lists of users.
  4. Fix bug where the wrong AppBarTitle would appear on Facility > All Facilities Page

Reviewer guidance

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jonboiser jonboiser added the TODO: needs review Waiting for review label Jun 24, 2020
@jonboiser jonboiser added this to the 0.14.0 milestone Jun 24, 2020
@jonboiser jonboiser changed the title Permissions page fixes caused by "unique username" assumption Fix bugs in Permissions pages caused by "unique username" assumption Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #7182 into release-v0.14.x will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
...ssets/src/views/ManagePermissionsPage/UserGrid.vue 0.00% <0.00%> (ø)
...ice/assets/src/views/UserPermissionsPage/index.vue 0.00% <0.00%> (ø)
...lugins/facility/assets/src/views/FacilityIndex.vue 0.00% <0.00%> (ø)
kolibri/utils/logger.py 82.50% <0.00%> (-12.50%) ⬇️
kolibri/core/content/utils/channel_import.py 88.48% <0.00%> (-0.57%) ⬇️
.../core/deviceadmin/management/commands/dbrestore.py 76.56% <0.00%> (ø)

@jonboiser jonboiser merged commit 4273078 into learningequality:release-v0.14.x Jul 1, 2020
@jonboiser jonboiser deleted the permissions-page-fixes branch July 1, 2020 00:42
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants