Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacing when windowIsSmall for mobile buttons on channel import #7219

Conversation

nucleogenesis
Copy link
Member

@nucleogenesis nucleogenesis commented Jun 30, 2020

Summary

Fixes #7113 by adding conditional padding when windowIsSmall

Reviewer guidance

See the issue and then login as super admin and see that it is fixed. Check all screen sizes.

References

#7113


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@nucleogenesis nucleogenesis added the TODO: needs review Waiting for review label Jun 30, 2020
@nucleogenesis nucleogenesis added this to the 0.14.0 milestone Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #7219 into release-v0.14.x will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
...gins/device/assets/src/views/HeaderWithOptions.vue 0.00% <0.00%> (ø)
kolibri/utils/cli.py 64.24% <0.00%> (-1.35%) ⬇️

@jonboiser jonboiser merged commit 3bb5d96 into learningequality:release-v0.14.x Jun 30, 2020
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants