Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid JSON during morango sync #7226

Merged

Conversation

bjester
Copy link
Member

@bjester bjester commented Jun 30, 2020

Summary

Updates the content negotiation class to use default behavior for morango.

Reviewer guidance

  • Needs a GZIP enabled peer
  • Pull a facility first, make changes, then try to sync with the peer you pulled from (it should push)

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester added TODO: needs review Waiting for review DEV: backend Python, databases, networking, filesystem... python labels Jun 30, 2020
@bjester bjester added this to the 0.14.0 milestone Jun 30, 2020
@bjester
Copy link
Member Author

bjester commented Jun 30, 2020

@jredrejo Could you verify that removing the select_parser override works as expected with whatever prompted your multipart additions?

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #7226 into release-v0.14.x will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
kolibri/core/negotiation.py 100.00% <100.00%> (+16.66%) ⬆️
kolibri/utils/logger.py 82.50% <0.00%> (-12.50%) ⬇️
kolibri/plugins/app/utils.py 51.51% <0.00%> (-10.99%) ⬇️
.../core/deviceadmin/management/commands/dbrestore.py 76.56% <0.00%> (ø)
...oach/assets/src/views/plan/PlanQuizPreviewPage.vue 0.00% <0.00%> (ø)
.../src/views/plan/LessonContentPreviewPage/index.vue 0.00% <0.00%> (ø)
...c/views/plan/PlanLessonSelectionContentPreview.vue 0.00% <0.00%> (ø)
...ws/plan/LessonContentPreviewPage/SelectOptions.vue
...gins/device/assets/src/views/HeaderWithOptions.vue 0.00% <0.00%> (ø)

@rtibbles rtibbles merged commit e5b8eb8 into learningequality:release-v0.14.x Jul 1, 2020
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Aug 5, 2020
@bjester bjester deleted the content-negotiation branch July 15, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants