Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urls notation to make the share button URL accesible #7228

Merged

Conversation

kollivier
Copy link
Contributor

@kollivier kollivier commented Jun 30, 2020

Summary

Title says it all!

Reviewer guidance

Please wait to approve and merge until I can confirm that the whl built by this PR fixes the share button issue!

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@kollivier kollivier changed the base branch from develop to release-v0.14.x June 30, 2020 23:39
@kollivier kollivier requested a review from rtibbles June 30, 2020 23:39
@kollivier kollivier self-assigned this Jun 30, 2020
@kollivier kollivier added the work-in-progress Not ready for review label Jun 30, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #7228 into release-v0.14.x will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
kolibri/core/assets/src/utils/appCapabilities.js 27.27% <0.00%> (ø)
.../views/language-switcher/LanguageSwitcherModal.vue 23.52% <0.00%> (-9.81%) ⬇️
...libri/plugins/user/assets/src/views/SignInPage.vue 33.33% <0.00%> (-0.87%) ⬇️
kolibri/utils/system.py 28.85% <0.00%> (-0.56%) ⬇️
...lugins/facility/assets/src/views/FacilityIndex.vue 0.00% <0.00%> (ø)
...ice/assets/src/views/UserPermissionsPage/index.vue 0.00% <0.00%> (ø)
...ssets/src/views/ManagePermissionsPage/UserGrid.vue 0.00% <0.00%> (ø)
kolibri/utils/cli.py 64.73% <0.00%> (+0.48%) ⬆️
kolibri/core/negotiation.py 100.00% <0.00%> (+16.66%) ⬆️

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fix is correct, but will not approve until the share button working has been confirmed!

@kollivier kollivier added TODO: needs review Waiting for review and removed work-in-progress Not ready for review labels Jul 1, 2020
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is correct, and confirmed as working!

@rtibbles rtibbles merged commit fa9ea9e into learningequality:release-v0.14.x Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants