Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close language modal when language not changed #7231

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Jul 1, 2020

Summary

Close language dialog and do not send a request when a language not changed.

Reviewer guidance

  1. Open Change language modal (can be opened from app bar menu, signin page footer or during setup wizard)
  2. Do not change language selection
  3. Click Confirm

References

Closes #7067


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob added the TODO: needs review Waiting for review label Jul 1, 2020
@MisRob MisRob added this to the 0.14.0 milestone Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #7231 into release-v0.14.x will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
.../views/language-switcher/LanguageSwitcherModal.vue 23.52% <0.00%> (-9.81%) ⬇️
kolibri/core/content/utils/check_schema_db.py 91.30% <0.00%> (-8.70%) ⬇️
.../core/deviceadmin/management/commands/dbrestore.py 76.56% <0.00%> (ø)

@jonboiser jonboiser self-assigned this Jul 1, 2020
@jonboiser jonboiser merged commit 8c1a495 into learningequality:release-v0.14.x Jul 1, 2020
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Jul 1, 2020
@MisRob MisRob deleted the language-switcher-same-language branch June 12, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants