Progress fetching url limiting

[rtibbles]

Summary

• We always fetched content node progress by content node ids
• This sometimes led to fetches having very long URIs
• This broke on some setups, due to limits on URI length
• Fixes this by:
  • Fetching content node progress for topic children by their parent id
  • Fetching content node progress for lesson resource by the lesson id
  • Only fetching content node progress for displayed content nodes in the recommended page
  • Batching requests for content node progress for recommended subpage to fetch 50 ids at a time

Reviewer guidance

Check that progress loads in a lesson, in a topic, and on the main recommended page and on recommended subpages.

References

I thought there was an issue for this, but I can't find it for the life of me.

Contributor Checklist

PR process:

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Testing:

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

Reviewer Checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[jonboiser]

I think we've talked informally about this happening, but there's no specific issue about adding these filters.

Maybe this issue is relevant? #5041

[rtibbles]

Yeah - that seems related. Not sure it will fix the vue dev tools part or not.

[indirectlylit]

Also possibly related - #6466 (comment)

I'm able to reproduce this issue by going to the Recommended tab on our main kolibri demo server. My guess is that the the request URL for contentnodeprogress endpoint is too long with the number of node ids.

[jonboiser]

I'm not seeing the progress bar on the Recommended Subpages cards, but the progress is coming over the wire

[jonboiser]

Devtools output for the "5+6" card on the main Recommended Page (with Progress = 1)

Output on the subpage (Progress = 0)

The Vuex mutation for setting progress is going through, but it must not be setting the Card props correctly at the end.

[codecov]

Codecov Report

Merging #7434 into release-v0.14.x will decrease coverage by 0.05%.
The diff coverage is 10.81%.

Impacted Files	Coverage Δ
kolibri/plugins/learn/assets/src/constants.js	100.00% <ø> (ø)
...gins/learn/assets/src/modules/recommended/index.js	0.00% <ø> (ø)
...plugins/learn/assets/src/views/RecommendedPage.vue	0.00% <0.00%> (ø)
...gins/learn/assets/src/views/RecommendedSubpage.vue	0.00% <0.00%> (ø)
kolibri/core/content/api.py	88.45% <40.00%> (-1.11%)	⬇️
kolibri/core/tasks/utils.py	87.03% <0.00%> (-5.56%)	⬇️
kolibri/core/content/utils/channel_import.py	88.48% <0.00%> (-0.57%)	⬇️
...s/device/assets/src/views/FacilitiesPage/index.vue	0.00% <0.00%> (ø)

[rtibbles]

Hrm - curious, will look into this!

[jonboiser]

So, it seems that the state for the "Most popular" subpage is actually this subpage sub-module. And it's getting all the card info + progresses from state.recommended.subpage.recommendations, whereas the created hook is only updating the state.recommended.popular stuff. I think maybe we should just get rid of this recommended/subpage submodule and read directly from the main recommended module

[rtibbles]

Thanks - I'll make that alteration, seems like a decent cleanup.

[rtibbles]

Updated!

[jonboiser]

Looks good. I think these lines are now dead code if you can clean it up

https://github.com/rtibbles/kolibri/blob/58d41d5760ac4eb4f14716cccb990b2b2903f51d/kolibri/plugins/learn/assets/src/constants.js#L45-L48

[rtibbles]

Done!

[jonboiser]

Looks good!