Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ContentNode filters with no implementation #7509

Merged

Conversation

jonboiser
Copy link
Contributor

Summary

Removes some filters from the ContentNodeFilter that don't appear to have an implementing method and have been supplanted by other API endpoints.

Reviewer guidance

Does this break anything?

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jonboiser jonboiser added this to the 0.15.0 milestone Sep 9, 2020
@jonboiser jonboiser added the TODO: needs review Waiting for review label Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #7509 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted Files Coverage Δ
kolibri/core/content/api.py 88.71% <ø> (-0.15%) ⬇️
kolibri/utils/logger.py 82.50% <0.00%> (-12.50%) ⬇️

@rtibbles rtibbles merged commit 17192de into learningequality:develop Sep 9, 2020
@jonboiser jonboiser deleted the unused-contentnode-filters branch September 9, 2020 22:13
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants