Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid database lock errors by always updating progress in the main thread #7676

Merged

Conversation

kollivier
Copy link
Contributor

Summary

It's possible to encounter SQLite database locked errors when concurrently writing progress updates from multiple threads. This fix prevents this from happening by having the main import thread perform all db updates.

Reviewer guidance

Testing import when running Kolibri on slower devices like Raspberry Pi and Android with larger channel imports should be enough to confirm that this is fixed.

References

Fixes #7673


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense - @radinamatic would you be able to take an asset for a spin to test?

@jonboiser jonboiser added this to the 0.14.4 milestone Nov 7, 2020
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine, and I can confirm it solves #7673 in a RPi, thanks!

@jonboiser jonboiser merged commit 4e55d87 into learningequality:release-v0.14.x Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing big channels in RPi is not possible due to db lock errors
4 participants