Avoid database lock errors by always updating progress in the main thread #7676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's possible to encounter SQLite database locked errors when concurrently writing progress updates from multiple threads. This fix prevents this from happening by having the main import thread perform all db updates.
Reviewer guidance
Testing import when running Kolibri on slower devices like Raspberry Pi and Android with larger channel imports should be enough to confirm that this is fixed.
References
Fixes #7673
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)