Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 6916: Copies of lessons don't reflect recent deletions or reordering of resources #7679

Merged
merged 1 commit into from Nov 10, 2020

Conversation

paulbusse
Copy link
Contributor

@paulbusse paulbusse commented Nov 9, 2020

Summary

Problem: when saving the changes made to the resources, the currentLesson was not updated.

  • Added an updateCurrentLesson also when the resources save succeeds to ensure that the memory image is aligned with the changes

Reviewer guidance

  • An alternate approach is to directly push the changes to currentLesson. This is probably more performant. This approach is probably more failsafe.
  • There are no visible frontend changes

References

Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

- added an updateCurrentLesson also when the resources save succeeds to
ensure that the memory image refers to the changes resources in this
file (Remove lesson or reorder lesson)
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #7679 (f3fe001) into develop (deb8fb3) will decrease coverage by 23.62%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
...views/plan/LessonSummaryPage/ResourceListTable.vue 0.00% <0.00%> (ø)
...i/plugins/user/assets/src/views/FacilitySelect.vue 0.00% <0.00%> (-27.28%) ⬇️
.../plugins/user/assets/src/views/ProfileEditPage.vue 0.00% <0.00%> (-19.05%) ⬇️
...s/src/views/plan/assignments/RecipientSelector.vue 44.11% <0.00%> (-7.89%) ⬇️
kolibri/core/assets/src/state/store.js 93.75% <0.00%> (-6.25%) ⬇️
kolibri/core/assets/src/views/GlobalSnackbar.vue 12.50% <0.00%> (-5.69%) ⬇️
kolibri/core/assets/src/router.js 37.50% <0.00%> (-5.36%) ⬇️
kolibri/core/assets/src/kolibri_app.js 83.33% <0.00%> (-2.39%) ⬇️
...rd/assets/src/views/onboarding-forms/YesNoForm.vue 92.30% <0.00%> (-0.55%) ⬇️
...ews/plan/assignments/IndividualLearnerSelector.vue 17.64% <0.00%> (-0.07%) ⬇️
... and 340 more

@paulbusse paulbusse changed the title views/plan/LessonSummaryPage/ResourceListTable.vue:AutoSave Fixing 6916: Copies of lessons don't reflect recent deletions or reordering of resources Nov 10, 2020
Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@jonboiser jonboiser merged commit 22270bd into learningequality:develop Nov 10, 2020
@paulbusse paulbusse deleted the issue6916 branch November 12, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants