Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display relevant text message when user selects a single resource while managing a channel #7909

Merged

Conversation

kmrinal19
Copy link
Contributor

@kmrinal19 kmrinal19 commented Mar 23, 2021

Summary

Fixes #7626 by displaying "Resource selected" message in place on "All resources selected" message when user selects a single resource while managing a channel.

Before:
resource_selection_before

After:
resource_selection_after

References

Fixes #7626


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jonboiser jonboiser added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) changelog Important user-facing changes labels Mar 23, 2021
@jonboiser jonboiser added this to the 0.15.0 milestone Mar 23, 2021
Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) changelog Important user-facing changes
Projects
None yet
2 participants