Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static files and zip content cleanup #7920

Merged
merged 5 commits into from Mar 25, 2021

Conversation

rtibbles
Copy link
Member

Summary

  • Uses Whitenoise for all static file serving
  • Removes use of collectstatic command and associated options.ini option
  • Adds static file serving to alternate origin server
  • Cleans up dead code for H5P serving that is obsolete with static file serving

Reviewer guidance

Do static files always load?
Do H5P files still render properly?

References

Fixes #7917
Fixes #7792

Screenshot of now functional swagger API explorer:
Screenshot from 2021-03-24 17-21-11


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Mar 25, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Mar 25, 2021
@jonboiser jonboiser self-assigned this Mar 25, 2021
Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! DRF APi Explorer, Swagger API explorer, static assets, and H5P work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important user-facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants