Make window.kolibri object available to Hashi iframe context
#7942
Conversation
packages/hashi/src/mainClient.js
Outdated
| } else if (options.parent) { | ||
| getParams.parent = options.parent; | ||
| } | ||
| options.ids ? (getParams.ids = options.ids) : null; |
There was a problem hiding this comment.
It's purely personal preference, but I find this in-line ternary operator to conditionalize assignment a bit hard to read.
You could also achieve the effect you want here by using the lodash helper function pick https://lodash.com/docs/4.17.15#pick
const getParams = pick(options, ['ids' ,'page', 'pageSize', 'parent']);
if (getParams.parent === 'self') {
...
}
Pick will only assign defined properties.
packages/hashi/src/mainClient.js
Outdated
|
|
||
| // if filtering by optional params | ||
| if (message.options) { | ||
| let getParams = {}; |
There was a problem hiding this comment.
Can use const for both getParams and options here as you are never reassigning their values. You've assigned it to an object, and even though you are changing the attributes of that object, you are not changing the referent of the variable.
packages/hashi/src/mainClient.js
Outdated
| } | ||
|
|
||
| __getOrUpdateContext(message) { | ||
| // to update context with the incoming context |
There was a problem hiding this comment.
Note we need to do the URI encoding and decoding of the context here.
| @@ -50,6 +52,37 @@ class Mediator { | |||
| this.remote.postMessage(message, '*'); | |||
| } | |||
|
|
|||
| // a function to manage messages for kolibri.js, | |||
| // when most messages require a response, to minimize redundancy | |||
| sendMessageAwaitReply({ event, data, nameSpace }) { | |||
| return new Promise((resolve, reject) => { | ||
| const msgId = uuidv4(); | ||
| function handler(message) { | ||
| if (message.message_id === msgId && message.type === 'response') { |
There was a problem hiding this comment.
Once we've received the corresponding message, would be good to unregister the message handler for cleanup.
packages/hashi/src/mainClient.js
Outdated
| @@ -59,6 +63,18 @@ export default class MainClient { | |||
| }); | |||
| }); | |||
| this.mediator.sendMessage({ nameSpace, event: events.READYCHECK, data: true }); | |||
|
|
|||
| this.on(this.events.DATAREQUESTED, message => { | |||
| this.__fetchContentData(message); | |||
There was a problem hiding this comment.
I am surprised you have not needed to call .bind on any of the handlers you have here.
…and begin refactoring mainClient
…date getParams in filtering functions
marcellamaki
force-pushed
the
custom-channels-working-branch
branch
from
55ba11f
to
549a610
Compare
marcellamaki
force-pushed
the
custom-channels-working-branch
branch
from
549a610
to
3d3b06b
Compare
…ough dependency injection
…s an empty object
marcellamaki
force-pushed
the
custom-channels-working-branch
branch
from
b93ba75
to
1afd9dc
Compare
marcellamaki
added
TODO: needs review
jonboiser
changed the title
window.kolibri object available to Hashi iframe context
This is very much a draft/WIP PR that is working to establish the foundation for a kolibri object and the core MVP functions.
Some functions are fully working, some are WIP with elements of pseudo code, as I need a more well-thought-out strategy for doing manual QA in some places. The new data-fetching code in
mainClient.jsshould most likely be relocated to another file - maybe ahandlers.js, or within the custom channels vue file which is not yet finished (TBD).I am also not sure if
__navigateTo()is doing enough, and if it's not, what exactly needs to be adjusted/added.