Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run iceqube tests on postgres. #7975

Merged
merged 4 commits into from Apr 27, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 7, 2021

Summary

  • Supersedes force utf8 decoding for SQL Alchemy types #7295
  • Ensures that iceqube tests run on postgres by using kolibri options to set postgres settings in tests rather than a separate settings file
  • Adds client_encoding argument when connecting to postgres with SQLAlchemy

Reviewer guidance

If tests still pass this should be good to go.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the 0.15.0 milestone Apr 7, 2021
@rtibbles rtibbles force-pushed the force-utf8-for-job-storage branch 7 times, most recently from 08da23f to fbf1ecc Compare April 12, 2021 01:47
@rtibbles rtibbles added the TODO: needs review Waiting for review label Apr 27, 2021
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@bjester bjester merged commit 2e41b45 into learningequality:develop Apr 27, 2021
@rtibbles rtibbles mentioned this pull request May 12, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants