Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KOLIBRI_ENABLE_CUSTOM_CHANNEL_NAV - default True to options.py #8025

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Add KOLIBRI_ENABLE_CUSTOM_CHANNEL_NAV - default True to options.py #8025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dc2e22
add DISABLE_CUSTOM_CHANNEL_NAV - default false to options.py
nucleogenesis Apr 23, 2021
167ec37
move option to be specified in Learn plugin
nucleogenesis Apr 28, 2021
b78cf2e
insert the value into the bootstrapped plugin_data
nucleogenesis Apr 28, 2021
50fad44
lint
nucleogenesis Apr 28, 2021
6e5aa01
make it an *ENABLE* option, capital-case the plugin namespace, prefix…
nucleogenesis Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions kolibri/plugins/learn/kolibri_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@
from kolibri.core.webpack import hooks as webpack_hooks
from kolibri.plugins import KolibriPluginBase
from kolibri.plugins.hooks import register_hook
from kolibri.utils import conf


class Learn(KolibriPluginBase):
untranslated_view_urls = "api_urls"
translated_view_urls = "urls"
kolibri_options = "options"


@register_hook
Expand Down Expand Up @@ -51,6 +53,9 @@ def plugin_data(self):
return {
"allowGuestAccess": get_device_setting("allow_guest_access"),
"allowLearnerUnassignedResourceAccess": allow_learner_unassigned_resource_access(),
"enableCustomChannelNav": conf.OPTIONS["Learn"][
"KOLIBRI_ENABLE_CUSTOM_CHANNEL_NAV"
],
}


Expand Down
9 changes: 9 additions & 0 deletions kolibri/plugins/learn/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
option_spec = {
"Learn": {
"KOLIBRI_ENABLE_CUSTOM_CHANNEL_NAV": {
"type": "boolean",
"default": False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue asks for this to be disabled by default, so if the flag is going to be DISABLE then this should default to True!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it into an ENABLE name instead

"envvars": ("KOLIBRI_ENABLE_CUSTOM_CHANNEL_NAV",),
},
},
}