New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ContentModal to display resources within the context of a Custom Channel Renderer #8040
Add ContentModal to display resources within the context of a Custom Channel Renderer #8040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a code read through and looks good so far. I'm going to do another round of manual QA in the morning and one more read through tomorrow with a fresh brain, and see if I can test out some of the custom themes also. @rtibbles if you have time for a quick review also to see if I missed anything, then I can go ahead and approve after I go through the manual QA in the morning 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the version()
change, this looks good to me! Nice work @jonboiser. @rtibbles is going to do one more pass to make sure I didn't miss anything, but looks like we are ready to demo tomorrow ✅ 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing jumped out at me during a read through.
Summary
ContentModal
component (which is similar toContentPage
), and integrates it to theCustomContentRenderer
component (which renders the custom channel's HTML5 App)themeRenderer
method to thewindow.kolibri
object provided by hashiversion
getter towindow.kolibri
themeValidator
utility to sanitize themes provided by the custom channel app and, if needed, provide warnings or errors. Uses thetinycolor2
library to parse/manipulate colors./Learn/CustomChannel
for organizationTopicsPage
context
query param would cause a refreshDemo of modal with custom theme and responsive behavior
References
Fixes #7832
Fixes #7833
Reviewer guidance
export KOLIBRI_ENABLE_CUSTOM_CHANNEL_NAV=True
export KOLIBRI_CENTRAL_CONTENT_BASE_URL=https://hotfixes.studio.learningequality.org
before running the devserer
favim-zinul
If possible, add a new custom channel with a different theme and see how the theme validation works.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)