Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout of DeviceSettingsPage; add labels to sections; add tests #8088

Merged
merged 8 commits into from May 18, 2021

Conversation

jonboiser
Copy link
Contributor

@jonboiser jonboiser commented May 14, 2021

Summary

  1. Updates layout of DeviceSettingsPage (nest dependent device setting, similar to facility setting #7247)
  2. Adds labels for the "External devices" section and the "Default landing page" section
  3. Adds tests that should cover state hydration after fetching device settings, as well as re-saving them (and does this by simulating a user clicking on the forms).

Screenshot:

image

Some videos:

  1. Checking that the changes are persisted + hydrated correctly
  2. Using the form with keyboard only

References

Fixes #7247

Reviewer guidance

Due to #8087, it might not be able to confirm the settings have changed by using the app. Instead, you might need to go to the API explorer (http://localhost:8000/api_explorer/) and call the devicesettings end point.

Video of me confirming this on Swagger API Explorer


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jonboiser jonboiser added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) changelog Important user-facing changes gherkin update An issue that only requires updating Gherkin stories for a feature TODO: needs gherkin update Add to our manual integration tests and removed gherkin update An issue that only requires updating Gherkin stories for a feature labels May 14, 2021
@jonboiser jonboiser requested a review from sairina May 14, 2021 22:54
Copy link
Contributor

@sairina sairina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtibbles rtibbles merged commit 8d8d15d into learningequality:develop May 18, 2021
@jonboiser jonboiser deleted the nested-device-settings branch May 20, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) changelog Important user-facing changes TODO: needs gherkin update Add to our manual integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nest dependent device setting, similar to facility setting
3 participants