Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On crowdin server $formatRelative (and other APIs) should use the interpolated locale (and not 'ach-ug') #8100

Merged
merged 2 commits into from May 20, 2021

Conversation

jonboiser
Copy link
Contributor

@jonboiser jonboiser commented May 20, 2021

Summary

  1. Adds a guard in the i18n setup code that pulls the real language code from localStorage (on the Crowdin server) and uses that to configure VueIntl's bootstrapping.

References

Fixes #7330 , but this is only confirmed locally. Will need to reconfirm once it is redeployed to the translation server.

Reviewer guidance

@pcenov @radinamatic

Per #7330 (comment), local testing might not be perfect because of some issues with the state of the localizations. Regardless, the fix for the "relative time" message on the Facility > Data page in #7330. Can be tested by taking the code or generated pex and running kolibri start with the translation settings:

kolibri start --settings=kolibri.deployment.default.settings.translation

For some reason, not all of the text will be localized (especially the "Generated ..." message in the screenshots), but, in my testing, the relative time localization on the Facility > Data page does look to be fixed for all of the languages supported by Kolibri.

CleanShot 2021-05-20 at 11 34 40
CleanShot 2021-05-20 at 11 34 18
CleanShot 2021-05-20 at 11 34 00
CleanShot 2021-05-20 at 11 32 10


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jonboiser jonboiser added this to the 0.15.0 milestone May 20, 2021
@jonboiser jonboiser added i18n Issues with fonts and translations in localizations TODO: needs review Waiting for review labels May 20, 2021
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to make a further suggestion about setting the languageDirection too - but then realized that would require more extensive changes, as we would need to appropriately load the directional CSS too, and that is bootstrapped into the page.

@rtibbles rtibbles merged commit 459ce3a into learningequality:develop May 20, 2021
@jonboiser jonboiser removed the TODO: needs review Waiting for review label May 20, 2021
@jonboiser jonboiser deleted the fix-intl-on-crowdin branch May 25, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues with fonts and translations in localizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intl.RelativeTimeFormat is not displaying correctly for Crowdin server's special ach-ug locale
2 participants