On crowdin server $formatRelative
(and other APIs) should use the interpolated locale (and not 'ach-ug')
#8100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #7330 , but this is only confirmed locally. Will need to reconfirm once it is redeployed to the translation server.
Reviewer guidance
@pcenov @radinamatic
Per #7330 (comment), local testing might not be perfect because of some issues with the state of the localizations. Regardless, the fix for the "relative time" message on the Facility > Data page in #7330. Can be tested by taking the code or generated pex and running
kolibri start
with the translation settings:For some reason, not all of the text will be localized (especially the "Generated ..." message in the screenshots), but, in my testing, the relative time localization on the Facility > Data page does look to be fixed for all of the languages supported by Kolibri.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)