Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #8119
Reviewer guidance
Make sure Kolibri starts up properly and then reacts properly to CTRL-C, or throwing any error during a call to register the zero conf service, or start one of the worker threads.
Noting that I have observed recently that a command prompt will display and then further logging text will happen after the CTRL-C - I am at a loss to work out how to prevent this, as the way that magicbus handles signal handlers is the way that every StackOverflow post recommends to try to handle this, so I am at a loss as to how to resolve it.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)