Expose vue composition api through apiSpec (kolibri.lib.vueCompositionApi
), so it is available to all SPAs
#8146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original PR that brought Vue Composition did not properly install the plugin for all SPAs (for reasons I don't understand). However, if it is bundled into apiSpec and exposed via
kolibri.lib.vueCompositionApi
, it works 馃しSo this PR
kolibri.lib.vueCompositionApi
the primary way to import Vue Composition API into your componentsReferences
This issue is blocking #8137 , since the current implementation makes heavy use of the composition API.
Reviewer guidance
Again, this refactor is a pretty straightforward mapping of Vue options -> composition functions, with a little sugar from
vueuse/core
. The app should work exactly as before.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)