Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 compatibility fixes #8159

Merged
merged 3 commits into from Jun 17, 2021
Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 17, 2021

Summary

  • Removes use of Promise.finally from Kolibri application code as polyfilling it within babel/preset-env has led to difficult to resolve issues
  • Consolidates and makes explicit our browserslist - and removes use of 'last 2 versions' so that we don't experience progressive browser support drift
  • Restores explicit polyfills for Hashi, as using babel/preset-env entry bloats the code enormously and usage results in runtime errors

References

Reviewer guidance

  • Testing that the learn page loads on IE11
  • Checking that HTML5 apps run on IE11

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jun 17, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Jun 17, 2021
@radinamatic
Copy link
Member

radinamatic commented Jun 17, 2021

IE11 is not blocked anymore by the Promise polyfill, goes smoothly through the setup wizard and channel import, Learn page looks OK.
There are issues loading resources, but it seems to be a general Windows backend issue (not extant on Linux with asset from the same build), we are going to address it as a separate issue/PR.

Win7 (start)  Running  - Oracle VM VirtualBox_043

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polyfill issue fixed, let's address the broken resource loading on Windows separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promise.finally is not polyfilled properly for IE11
2 participants