Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

point develop at most recent KDS #8193

Merged
merged 1 commit into from Jul 8, 2021
Merged

point develop at most recent KDS #8193

merged 1 commit into from Jul 8, 2021

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Jul 8, 2021 •
edited

Summary

point Kolibri develop to the latest HEAD of KDS

References

points to learningequality/kolibri-design-system@cfcfc25

Reviewer guidance

Upgrades KDS using the following process:

  • get the most recent commit
  • update those two package.json files
  • run yarn

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@indirectlylit
upgrade KDS
7e27fcf 
process
* update two package.json files
* run yarn
@indirectlylit indirectlylit changed the title upgrade KDS point develop at most recent KDS Jul 8, 2021
@rtibbles rtibbles merged commit fdd2d26 into learningequality:develop Jul 8, 2021
@indirectlylit indirectlylit deleted the kds-upgrade branch August 20, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

@sairina sairina Awaiting requested review from sairina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@indirectlylit @rtibbles