Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove group to preserve compatibility #8204

Merged
merged 1 commit into from Jul 14, 2021

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Jul 14, 2021

Summary

Removes group to fix errors generated due to outdated objects on db.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb
Copy link
Member Author

vkWeb commented Jul 14, 2021

cc @rtibbles @radinamatic for review.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves this specific issue - seems like we might need to stop pickling to handle the class of errors more generally.

@rtibbles rtibbles merged commit 44b47cb into learningequality:develop Jul 14, 2021
@vkWeb
Copy link
Member Author

vkWeb commented Jul 14, 2021

Yes, I agree.

After we finish decoupling the tasks and simplifying workers, we'll look into how to stop pickling altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants