Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions to SyncStatus model. #8205

Merged
merged 2 commits into from Jul 27, 2021

Conversation

rtibbles
Copy link
Member

Summary

  • Adds very simple read only + same facility permissions to the sync status model

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 14, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Jul 14, 2021
"""
For simplicity, let anyone from the same facility read the sync status
for now. In the future, we may want to restrict this, but it is not
sensitive information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model contains a foreignkey onto SyncSession, which means it directly stores the sync session ID, which is used as the "session token" (like a browser session_id cookie) for purposes of syncing -- if the syncsession is still active, anybody with that ID can sync within the scope of that sync session, without further certificate verification.

I'm not seeing anywhere in the codebase yet that pulls this model in to display in the frontend, but I'd recommend that it not send the sync session ID as part of that, instead just looking up the relevant fields (e.g. last_activity timestamp) across the foreignkey. If that were enforced, then it would perhaps be OK to leave these permissions as-is. But the safest would be to only allow access for someone who's a coach or admin for the target user.

Copy link
Member

@jamalex jamalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@rtibbles rtibbles changed the base branch from develop to release-v0.15.x July 27, 2021 17:58
@rtibbles rtibbles merged commit b87f9da into learningequality:release-v0.15.x Jul 27, 2021
@rtibbles rtibbles deleted the permissions branch July 27, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants