Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small code quality cleanup #8206

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jul 14, 2021

Summary

  • Removes unused queryset argument from base method.
  • Stops shadowing built in filter function.

References

Cleanup from #7928

Reviewer guidance

Do tests still pass?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Stops shadowing built in filter function.
@rtibbles rtibbles requested a review from jredrejo July 14, 2021 14:58
@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 14, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Jul 14, 2021
@rtibbles
Copy link
Member Author

Tests pass. Merging.

@rtibbles rtibbles merged commit c3c7ac6 into learningequality:develop Jul 27, 2021
@rtibbles rtibbles deleted the permissions_code_quality branch July 27, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant