Add basic batch processing of notifications with tests. #8207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
force-pushed
the
batch_notifications
branch
from
91d298c
to
bf8fd3e
Compare
jredrejo
approved these changes
Jul 19, 2021
| @@ -483,3 +485,26 @@ def parse_attemptslog(attemptlog): | |||
|
|
|||
| if notifications: | |||
| save_notifications(notifications) | |||
|
|
|||
|
|
|||
| def batch_process_attemptlogs(attemptlog_ids): | |||
There was a problem hiding this comment.
appart from the tests, I don't see any place in the code where these batch_process_xxx functions are used. I guess there's another PR or issue were this is going to be worked, right?
There was a problem hiding this comment.
Yes - the issue this is fixing is dependent on the new morango version being merged into Kolibri, as it relies on being able to add a listener for syncing to get these updated ids.
I just wanted to get the code in first, and seems like it was useful. Will continue to chase down the Windows issues.
There was a problem hiding this comment.
Thanks!
then, ready to merge as soon as the Windows™ issues are solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Prerequisite work for #8188
Reviewer guidance
I initially implemented this, assuming that I would immediately have to optimize the batch processing - but then thought it might be better to get it in, do some tests, and then optimize if/where it is needed.
Testing checklist
PR process
Reviewer checklist
yarnandpip)